Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actually name Limitador's RL #334

Closed
wants to merge 2 commits into from
Closed

Actually name Limitador's RL #334

wants to merge 2 commits into from

Conversation

alexsnaps
Copy link
Member

Follow up to #301 - actually name the RateLimit from the RateLimitPolicy's NS & name…

@alexsnaps alexsnaps requested a review from a team as a code owner November 23, 2023 13:44
@alexsnaps alexsnaps requested a review from eguzki November 23, 2023 13:44
@alexsnaps alexsnaps added this to the v0.5.0 milestone Nov 23, 2023
@alexsnaps alexsnaps added kind/enhancement New feature or request target/current labels Nov 23, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 23, 2023 •
edited
Loading

Codecov Report

Merging #334 (dc03147) into main (83228b0) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #334      +/-   ##
==========================================
+ Coverage   64.76%   64.84%   +0.08%     
==========================================
  Files          35       35              
  Lines        3789     3792       +3     
==========================================
+ Hits         2454     2459       +5     
+ Misses       1144     1143       -1     
+ Partials      191      190       -1
Flag Coverage Δ
integration 70.63% <ø> (+0.09%) ⬆️
unit 58.27% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) ∅ <ø> (∅)
pkg/common (u) 73.92% <ø> (ø)
pkg/istio (u) 30.24% <ø> (ø)
pkg/log (u) 31.81% <ø> (ø)
pkg/reconcilers (u) 33.68% <ø> (ø)
pkg/rlptools (u) 56.82% <100.00%> (+0.41%) ⬆️
controllers (i) 70.63% <ø> (+0.09%) ⬆️
Files Coverage Δ
pkg/rlptools/utils.go 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@alexsnaps
Copy link
Member Author

@eguzki
Do you know what this failure is about?

2023/11/23 15:41:25 render reference "quay.io/kuadrant/kuadrant-operator-bundle:named-RL": error resolving name : quay.io/kuadrant/kuadrant-operator-bundle:named-RL: not found

@alexsnaps alexsnaps closed this Nov 23, 2023
@alexsnaps alexsnaps deleted the named-RL branch November 23, 2023 15:52
@alexsnaps alexsnaps mentioned this pull request Nov 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eguzki eguzki Awaiting requested review from eguzki

Assignees
No one assigned
Labels
kind/enhancement New feature or request
Projects
Kuadrant
Archived in project
Kuadrant Service Protection
Status: To test
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.
1 participant
@alexsnaps